1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889 |
- <?php
- /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
- */
- namespace Magento\Test\Php;
- use Magento\Framework\App\Utility\Files;
- use Magento\TestFramework\Utility\XssOutputValidator;
- use Magento\Framework\Component\ComponentRegistrar;
- /**
- * Find not escaped output in phtml templates
- */
- class XssPhtmlTemplateTest extends \PHPUnit\Framework\TestCase
- {
- /**
- * @return void
- */
- public function testXssSensitiveOutput()
- {
- $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
- $xssOutputValidator = new XssOutputValidator();
- $invoker(
- /**
- * Static test will cover the following cases:
- *
- * 1. /\* @noEscape \*\/ before output. Output doesn't require escaping. Test is green.
- * 2. Methods which contains "html" in their names (e.g. echo $object->{suffix}Html{postfix}() ).
- * Data is ready for the HTML output. Test is green.
- * 3. AbstractBlock methods escapeHtml, escapeUrl, escapeQuote, escapeXssInUrl are allowed. Test is green.
- * 4. Type casting and php function count() are allowed
- * (e.g. echo (int)$var, echo (float)$var, echo (bool)$var, echo count($var)). Test is green.
- * 5. Output in single quotes (e.g. echo 'some text'). Test is green.
- * 6. Output in double quotes without variables (e.g. echo "some text"). Test is green.
- * 7. Other of p.1-6. Output is not escaped. Test is red.
- *
- * @param string $file
- */
- function ($file) use ($xssOutputValidator) {
- $lines = $xssOutputValidator->getLinesWithXssSensitiveOutput($file);
- $this->assertEmpty(
- $lines,
- "Potentially XSS vulnerability. " .
- "Please verify that output is escaped at lines " . $lines
- );
- },
- Files::init()->getPhtmlFiles()
- );
- }
- /**
- * @return void
- */
- public function testAbsenceOfEscapeNotVerifiedAnnotationInRefinedModules()
- {
- $componentRegistrar = new ComponentRegistrar();
- $exemptModules = [];
- foreach (array_diff(scandir(__DIR__ . '/_files/whitelist/exempt_modules'), ['..', '.']) as $file) {
- $exemptModules = array_merge(
- $exemptModules,
- include(__DIR__ . '/_files/whitelist/exempt_modules/' . $file)
- );
- }
- $result = "";
- foreach ($componentRegistrar->getPaths(ComponentRegistrar::MODULE) as $moduleName => $modulePath) {
- if (in_array($moduleName, $exemptModules)) {
- continue;
- }
- foreach (Files::init()->getFiles([$modulePath], '*.phtml') as $file) {
- $fileContents = file_get_contents($file);
- $pattern = "/\\/* @escapeNotVerified \\*\\/ echo (?!__).+/";
- $instances = preg_grep($pattern, explode("\n", $fileContents));
- if (!empty($instances)) {
- foreach (array_keys($instances) as $line) {
- $result .= $file . ':' . ($line + 1) . "\n";
- }
- }
- }
- }
- $this->assertEmpty(
- $result,
- "@escapeNotVerified annotation detected.\n" .
- "Please use the correct escape strategy and remove annotation at:\n" . $result
- );
- }
- }
|